Skip to content

Update CODE_OF_CONDUCT.md#4167

Open
SuleimanKarimEddin wants to merge 2 commits intoobjectionary:masterfrom
SuleimanKarimEddin:master
Open

Update CODE_OF_CONDUCT.md#4167
SuleimanKarimEddin wants to merge 2 commits intoobjectionary:masterfrom
SuleimanKarimEddin:master

Conversation

@SuleimanKarimEddin
Copy link

No description provided.

@github-actions github-actions bot added the core label May 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2025

🚀 Performance Analysis

All benchmarks are within the acceptable range. No critical degradation detected (threshold is 100%). Please refer to the detailed report for more information.

Click to see the detailed report
Test Base Score PR Score Change % Change Unit Mode
benchmarks.XmirBench.xmirToEO 136.407 137.923 1.516 1.11% ms/op Average Time
benchmarks.XmirBench.xmirToPhi 129.119 150.226 21.107 16.35% ms/op Average Time
benchmarks.XmirBench.xmirToSaltyPhi 145.042 144.563 -0.479 -0.33% ms/op Average Time

⚠️ Performance loss: benchmarks.XmirBench.xmirToEO is slower by 1.516 ms/op (1.11%)
⚠️ Performance loss: benchmarks.XmirBench.xmirToPhi is slower by 21.107 ms/op (16.35%)
✅ Performance gain: benchmarks.XmirBench.xmirToSaltyPhi is faster by 0.479 ms/op (0.33%)

@0crat
Copy link

0crat commented May 14, 2025

@SuleimanKarimEddin Hi there! I noticed that the branch name "master" doesn't follow our naming convention. As per our guidelines, branch names should match the ticket number you're working on. This helps with organization and tracking. Unfortunately, this means a deduction of 12 points. For future reference, a branch name like "4166" would be perfect. Let's keep improving our workflow together! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants